fix: plug memory leak in jest-circus when running in band#9934
Conversation
|
aight, leaks
|
jeysal
left a comment
jeysal
left a comment
There was a problem hiding this comment.
Nice, I believe the screenshots you posted on the chat but obviously let's look at CI 😅
One nit that I believe would be nice for clarity, even though we have a test
|
|
||
| _addSnapshotData(results, snapshotState); | ||
|
|
||
| return deepCyclicCopy(results); |
There was a problem hiding this comment.
I'd say perhaps a comment, and definitely {keepPrototype: false} would be nice to explain this?
There was a problem hiding this comment.
50/50 if I get Prettier's brace spacing right 😂
|
woo |
Codecov Report
@@ Coverage Diff @@
## master #9934 +/- ##
=======================================
Coverage 64.23% 64.23%
=======================================
Files 292 292
Lines 12466 12466
Branches 3075 3075
=======================================
Hits 8007 8007
Misses 3810 3810
Partials 649 649
Continue to review full report at Codecov.
|
SimenB
changed the title
jeysal
left a comment
jeysal
left a comment
There was a problem hiding this comment.
LGTM if everything green
|
node 14 on windows is super flaky, all other is green |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
Summary
I have a fix for this, but I'm hoping CI will tell us it currently leaks, then I can push the fix.
Fixes #8816
Test plan
Activating the leaks checks on circus