Skip to content

Fix jest.spyOn() unit test in JestObjectAPI.md#14625

Merged
SimenB merged 6 commits intojestjs:mainfrom
faizanu94:patch-1
Dec 24, 2023
Merged

Fix jest.spyOn() unit test in JestObjectAPI.md#14625
SimenB merged 6 commits intojestjs:mainfrom
faizanu94:patch-1

Conversation

@faizanu94
Copy link
Copy Markdown
Contributor

@faizanu94 faizanu94 commented Oct 18, 2023

Summary

Since the exiting unit test mentioned at https://jestjs.io/docs/jest-object#jestspyonobject-methodname-accesstype gets failed dues to play being called as function, this PR fixes the test by accessing the play method as property due to its getter definition

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Oct 18, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 18, 2023 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 29b350b
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6585a9da7358fc0008478183
😎 Deploy Preview https://deploy-preview-14625--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SimenB
SimenB approved these changes Nov 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! can you update all versions of this docs, and sign the CLA?

@SimenB
Copy link
Copy Markdown
Member

SimenB commented Dec 2, 2023

@faizanu94 instructions for CLA is in this comment: #14625 (comment)

@faizanu94
Copy link
Copy Markdown
Contributor Author

faizanu94 commented Dec 6, 2023

@SimenB it's done, also updated all versions of docs - thanks!

@faizanu94
Copy link
Copy Markdown
Contributor Author

faizanu94 commented Dec 18, 2023

@SimenB few actions encountered a resource busy or locked error - can we initiate a rerun?

@faizanu94
Copy link
Copy Markdown
Contributor Author

faizanu94 commented Dec 21, 2023

Details

https://github.com/jestjs/jest/actions/runs/7114563518/job/19752161826?pr=14625

SimenB
SimenB approved these changes Dec 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! CI errors look like flake

@SimenB SimenB merged commit 5065e24 into jestjs:main Dec 24, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 24, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@faizanu94 @SimenB