Fix getOptions support for Windows machines
#215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Sorry for the delay. Thank you!! This looks pretty great to me and I'm happy to merge. I just need to ask that you remove the version bump in package.json first. I do the version bumping when cutting a new release. So once you do that I'll merge this and the other PR of yours and cut a release. |
Contributor
Author
|
Done! @palmerj3 |
Contributor
Author
Collaborator
|
Hey @mastrzyz sorry for the delay. Just started a new job this week. I'll carve out some time this weekend to get these things merged and published. |
Contributor
Author
|
@palmerj3 any luck with merging |
Contributor
Author
|
Hey @palmerj3 is there anyone else I can ping here for review? |
palmerj3
approved these changes
Jun 25, 2022
Collaborator
|
Sorry for the delay. I merged both your PRs and published version 14.0.0 with the changes. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue -> #107
Current
getOptionsgoes up the directory tree until we hitpath.sep, aka "/".This works on Nix based platforms but on windows we hit an infinite loop at
path.dirname("C:\\"), since we can't go to "/" from "C:\".Instead we should be leveraging
path.parsewhich actually tells us the root directory of a path.Added the incomplete UT for this as well as a try/catch around the require statement since it can also fail if the import isn't working like through bundling via webpack.