Replace <rootDir> prior to path.join().

Michael Johns · Michael Johns · commit c5ca7c86331b · 2021-09-30T15:25:20.000-07:00
This allows outputDirectory to be formatted like &lt;rootDir&gt;/../some/dir. In that case, path.join() assumes the .. cancels out the &lt;rootDir&gt;, which seems entirely reasonable. Unfortunately, it means the final value is some/dir, and that ends up rooted at process.cwd(), which doesn't always match &lt;rootDir&gt;.

Handling the &lt;rootDir&gt; replacement first allevaites this problem.
diff --git a/utils/getOutputPath.js b/utils/getOutputPath.js
@@ -7,7 +7,9 @@ module.exports = (options, jestRootDir)  => {
   if (!output) {
     // Set output to use new outputDirectory and fallback on original output
     const outputName = (options.uniqueOutputName === 'true') ? getOptions.getUniqueOutputName() : options.outputName
-    output = path.join(options.outputDirectory, outputName);  
+    output = getOptions.replaceRootDirInOutput(jestRootDir, options.outputDirectory);
+    const finalOutput = path.join(output, outputName);
+    return finalOutput;
   }
   
   const finalOutput = getOptions.replaceRootDirInOutput(jestRootDir, output);
