move to strip function

stevenxu-db · stevenxu-db · commit 4eb9517d4c5d · 2022-11-10T18:00:44.000-08:00
diff --git a/index.js b/index.js
@@ -34,12 +34,8 @@ const processor = (report, reporterOptions = {}, jestRootDir = null) => {
   // Ensure output path exists
   mkdirp.sync(path.dirname(outputPath));
 
-  // Clean ESC character, which is invalid XML and some libraries include in error messages
-  const xmlString = xml(jsonResults, { indent: '  ', declaration: true });
-  const cleanedXmlString = xmlString.replace(/\u001b/g, '');
-
   // Write data to file
-  fs.writeFileSync(outputPath, cleanedXmlString);
+  fs.writeFileSync(outputPath, xml(jsonResults, { indent: '  ', declaration: true }));
 
   // Jest 18 compatibility
   return report;
diff --git a/utils/buildJsonResults.js b/utils/buildJsonResults.js
@@ -74,7 +74,7 @@ const generateTestCase = function(junitOptions, suiteOptions, tc, filepath, file
     failureMessages.forEach((failure) => {
       const tagName = tc.status === testFailureStatus ? 'failure': testErrorStatus
       testCase.testcase.push({
-        [tagName]: stripAnsi(failure)
+        [tagName]: strip(failure)
       });
     })
   }
@@ -102,6 +102,11 @@ const addErrorTestResult = function (suite) {
   })
 }
 
+// Strips escape codes for readability and illegal XML characters to produce valid output.
+const strip = function (str) {
+  return stripAnsi(str).replace(/\u001b/g, '');
+}
+
 module.exports = function (report, appDirectory, options, rootDir = null) {
   // Check if there is a junitProperties.js (or whatever they called it)
   const junitSuitePropertiesFilePath = getTestSuitePropertiesPath(
