Fix a wrong test on quaternion identity in the viewer app#88
Merged
jessey-git merged 1 commit intojessey-git:masterfrom Sep 6, 2021
dimitri-tdg:master
Merged
Fix a wrong test on quaternion identity in the viewer app#88jessey-git merged 1 commit intojessey-git:masterfrom dimitri-tdg:master
jessey-git merged 1 commit intojessey-git:masterfrom
dimitri-tdg:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a small issue on the node transformation parsing in the gltf structure.
This modification has no consequence on the viewer app, it just bypasses quaternion to matrix conversion in some cases (except if the quaternion is equal to { 1, 1, 1, 1 } but not sure it can happen)