Renaming callback hooks and init_callback_context #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Sep 30, 2025
sklearn/callback/_progressbar.py
Outdated
Comment on lines
27
to
34
| def on_fit_begin(self, estimator): | ||
| """Callback hook called at the beginning of the estimator's fit method. | ||
| Parameters | ||
| ---------- | ||
| estimator : estimator instance | ||
| Estimator the callback is attached to. | ||
| """ |
Owner
There was a problem hiding this comment.
Let's tweak the sklearn.tests.test_docstrings test to ignore these methods. It can be done in get_all_methods. We can add something like
if isinstance(Klass, Callback) and name in ("on_fit_begin", "on_fit_end", "on_fit_task_end"):
continue
Author
There was a problem hiding this comment.
Yes, I also added the skip in sklearn.tests.test_docstring_parameters.
Co-authored-by: Jérémie du Boisberranger <[email protected]>
jeremiedbb
approved these changes
Sep 30, 2025
jeremiedbb
merged commit 5e75096
into
jeremiedbb:base_callbacks_2
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make callback hook functions public and use the skl dunders for
init_callback_context.