Remove CallbackContext's _depth property #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Sep 19, 2025
sklearn/callback/_progressbar.py
Outdated
Comment on lines
200
to
202
| depth = len(_get_task_info_path(task_info)) - 1 | ||
| indent = f"{' ' * depth}" | ||
| style = f"[{colors[(depth) % len(colors)]}]" |
Owner
There was a problem hiding this comment.
I'd like to avoid calling _get_task_info_path because it will be called for each node while we could build the depth during the tree building.
Let's define a depth attribute at init time as self.depth = 0 if parent is None else parent.depth + 1.
jeremiedbb
reviewed
Sep 19, 2025
| import pytest | ||
|
|
||
| from sklearn.callback._callback_context import CallbackContext | ||
| from sklearn.callback._progressbar import _get_task_info_path |
Owner
There was a problem hiding this comment.
Since we need it for metric monitor as well, let's directly move it in callback_context. Importing it from progressbar in test_callback_context feels off
…d move _get_task_info_path to _callback_context.py
jeremiedbb
reviewed
Sep 22, 2025
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
jeremiedbb
approved these changes
Sep 23, 2025
jeremiedbb
merged commit 12b921f
into
jeremiedbb:base_callbacks_2
13 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
CallbackContext's_depthproperty, as it can easily be obtained aslen(_get_task_info_path(self.task_info)).