Conversation
Owner
Author
|
@Tyriar This PR should remove most of the nasty init burden and initialize the canvas & the placeholder lazy. This is not the nicest PR, but gets the job done in local tests. For normal terminal usage w'o any image sequences there should not be any image canvas anymore on the DOM. Not quite sure how you can test it without going through the whole build burden (the bootstrapping is quite cumbersome I admit) - I can do a local bundle and put the file in a gist for testing, if you want. Edit: The changes are not that much, thus I dont mind transferring them myself. |
Tyriar
suggested changes
Jul 13, 2023
Owner
Author
|
@Tyriar The Pr is done. The changes got bigger than anticipated 😸 , whatever - gonna do a last patch release for these here, and apply the code changes in the base repo PR afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #55.