Repository navigation
Commit f0ac4d3
docs(rfc): keep datafusion statistics collection off by design (#1279)
* docs(rfc): keep datafusion statistics collection off by design
RFC 0021 §3.2a turned execution.collect_statistics off as a
workaround for apache/datafusion#24769, to drop once the fix shipped.
Testing 56.0.0-rc1 showed two open upstream bugs in the same
statistics-to-constant path: NaN rows of a float column read back as
the min == max statistic (#26490, wrong values for promoted Float64
attributes), and pruning still lost when the predicate holds a term
statistics can't evaluate (#27415, RFC0044.7).
The new §3.2c makes statistics off the intended design, says what it
costs (plan-time file statistics only; row-group pruning still runs),
and requires a later amendment with both bugs fixed, the guard tests
green and a B1/B2 run before turning it on. RFC0021.10 pins the NaN
case.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_0125HXBoGeZ4wPFs9hDidYSx
Signed-off-by: Jens Holdgaard Pedersen <[email protected]>
* docs(rfc): separate the nan behaviour test from the stats-off guard
RFC0021.10 named the statistics-off setting assertion alongside the NaN
behaviour test, so the criterion could never pass with statistics on.
The re-enable conditions now require only the behaviour test green, and
the later amendment rewrites the off-only clause and its assertion.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_0125HXBoGeZ4wPFs9hDidYSx
Signed-off-by: Jens Holdgaard Pedersen <[email protected]>
* test(querier): cite rfc0021.10 in the nan guard test
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_0125HXBoGeZ4wPFs9hDidYSx
Signed-off-by: Jens Holdgaard Pedersen <[email protected]>
---------
Signed-off-by: Jens Holdgaard Pedersen <[email protected]>
Co-authored-by: Claude Opus 5.5 <[email protected]>1 parent 54c2a59 commit f0ac4d3
2 files changed
Lines changed: 74 additions & 2 deletions
File tree
- crates/ourios-querier/tests/it
- docs/rfcs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
189 | | - | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
190 | 244 | | |
191 | 245 | | |
192 | 246 | | |
| |||
298 | 352 | | |
299 | 353 | | |
300 | 354 | | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
301 | 369 | | |
302 | 370 | | |
303 | 371 | | |
| |||
357 | 425 | | |
358 | 426 | | |
359 | 427 | | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
360 | 431 | | |
361 | 432 | | |
362 | 433 | | |
| |||
0 commit comments