Skip to content

Moving PushdStep here from workflow-basic-steps#293

Merged
jglick merged 1 commit into
jenkinsci:masterfrom
jglick:PushdStep
Feb 16, 2023
Merged

Moving PushdStep here from workflow-basic-steps#293
jglick merged 1 commit into
jenkinsci:masterfrom
jglick:PushdStep

Conversation

@jglick

@jglick jglick commented Feb 16, 2023

Copy link
Copy Markdown
Member

jenkinsci/workflow-basic-steps-plugin#86 (comment) #291 (comment)

Testing:

  • Run 2.387 on a fresh userdir. Install workflow-{job,cps,basic-steps,durable-task-step and pipeline-input-step. Configure and start a project
node {
    sh 'pwd'
    dir('subdir') {
        sh 'pwd'
        input 'proceed?'
        sh 'pwd'
    }
    sh 'pwd'
}
  • Install a snapshot build of this PR and restart.
  • Confirm that the running build is still running.
  • Run another project and confirm that it works, though DSL prints a warning:
node {
    sh 'pwd'
    dir('foo') {
        sh 'pwd'
    }
    sh 'pwd'
}
  • Check Pipeline Syntax to see that dir is offered, once, and the help button indicates that it comes from this plugin.
  • Install a snapshot build of Moved PushdStep to workflow-durable-task-step workflow-basic-steps-plugin#258 and restart.
  • Approve the running build and confirm that it prints the expected paths.
  • Run the second project. No warning this time.
  • Pipeline Syntax looks the same.

return new Execution(path, context);
}

@Extension(ordinal = 100) public static final class DescriptorImpl extends StepDescriptor {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added ordinal

Comment on lines +75 to +79
return Set.of(TaskListener.class, FilePath.class);
}

@Override public Set<? extends Class<?>> getProvidedContext() {
return Set.of(FilePath.class);

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switched to Set.of


}

public static class Execution extends StepExecution {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switched from AbstractStepExecutionImpl

@jglick
jglick merged commit dc0ad1f into jenkinsci:master Feb 16, 2023
@jglick
jglick deleted the PushdStep branch February 16, 2023 22:16
jglick added a commit to jglick/workflow-basic-steps-plugin that referenced this pull request Feb 16, 2023
froque added a commit to jenkinsci/plugin-usage-plugin that referenced this pull request Jun 28, 2023
Happend with org.jenkinsci.plugins.workflow.steps.PushdStep that was moved
from workflow-basic-steps-plugin to org.jenkinsci.plugins.workflow.support.steps.PushdStep
in workflow-durable-task-step-plugin

jenkinsci/workflow-basic-steps-plugin#258
jenkinsci/workflow-durable-task-step-plugin#293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants