Skip to content

Migrate Commons Lang from 2 to 3#361

Merged
jtnord merged 1 commit into
jenkinsci:masterfrom
gounthar:plugin-modernizer/migratecommonslang2tolang3andcommontext
Sep 9, 2025
Merged

Migrate Commons Lang from 2 to 3#361
jtnord merged 1 commit into
jenkinsci:masterfrom
gounthar:plugin-modernizer/migratecommonslang2tolang3andcommontext

Conversation

@gounthar

@gounthar gounthar commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Hello workflow-basic-steps developers! 👋

This is an automated pull request created by the Jenkins Plugin Modernizer tool. The tool has applied the following recipes to modernize the plugin:

Migrate Commons Lang from 2 to 3

io.jenkins.tools.pluginmodernizer.MigrateCommonsLang2ToLang3AndCommonText

Migrate Commons Lang from 2 to 3.

This pull request upgrades Apache Commons Lang 2 to Apache Commons Lang 3.

What's Changed?

  • Migrated from deprecated/EOL Apache Commons Lang 2 to Commons Lang 3.

@jtnord jtnord left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but the PR title and description are missleading as there is no migrtation of commons text.

This is not migrating StringEscapeUtils to commons text, it is migrating commans-lang v2 to commons-lang v3

@jtnord jtnord changed the title Migrate Commons Lang from 2 to 3 and StringEscapeUtils to Commons Text Migrate Commons Lang from 2 to 3 Sep 9, 2025
@jtnord
jtnord enabled auto-merge September 9, 2025 16:36
@gounthar

gounthar commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

Thanks, James.

@jtnord
jtnord merged commit e9c3cc3 into jenkinsci:master Sep 9, 2025
16 of 17 checks passed
@jglick

jglick commented Sep 9, 2025

Copy link
Copy Markdown
Member

I do not think the new dep is warranted for the trivial usages

(#56; should probably be replaced by an error in the constructor)
if (StringUtils.isBlank(step.subject) || StringUtils.isBlank(step.body)) {
(jenkinsci/pipeline-plugin@064966b; ditto)

@gounthar
gounthar deleted the plugin-modernizer/migratecommonslang2tolang3andcommontext branch September 9, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants