JENKINS-61474 Improve null safety of the tool step#302
Merged
Conversation
Tools page doesn't prevent submission of empty tool names. Some tools (e.g. Allure Commandline) use `Util.fixEmptyAndTrim` on the name, so there is a possibility of NPE when comparing the tool names. By flipping the comparison we avoid NPE since `tool` step requires `name` argument.
jtnord
approved these changes
Mar 5, 2024
jtnord
left a comment
jtnord
left a comment
Member
There was a problem hiding this comment.
Some tools (e.g. Allure Commandline) use Util.fixEmptyAndTrim on the name
sounds like a UX bug should be filed for these plugins? How does that render / work in dropdowns etc...
Member
Author
|
@jtnord it is either shown as blank item if plugin stores it as empty string or as
|
Member
please file bugs for the plugins that support null or the blank string then that you are aware of (or a general one for Jenkins core to prevent this - but this would break those tools installation definitions if/when merged without plugin changes). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tools page doesn't prevent submission of empty tool names. Some tools (e.g. Allure Commandline) use
Util.fixEmptyAndTrimon the name, so there is a possibility of NPE when comparing the tool names. By flipping the comparison we avoid NPE sincetoolstep requiresnameargument.This most likely fixes https://issues.jenkins.io/browse/JENKINS-61474
Testing done