Skip to content

Update parent#265

Merged
jglick merged 2 commits into
jenkinsci:masterfrom
jglick:parent
Apr 10, 2023
Merged

Update parent#265
jglick merged 2 commits into
jenkinsci:masterfrom
jglick:parent

Conversation

@jglick

@jglick jglick commented Mar 22, 2023

Copy link
Copy Markdown
Member

Supersedes #264 & #261, and part of #263.

@jglick
jglick requested a review from a team as a code owner March 22, 2023 17:38
@jglick jglick added the chore label Mar 22, 2023
Comment thread pom.xml
<artifactId>mock-javamail</artifactId>
<version>2.0</version>
<scope>test</scope>
<exclusions>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: A note explaining why would be interesting

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty standard exclusion used in various plugins IIRC. I am a bit hesitant to leave comments with too many details with such cases because if you doubt that an exclusion is still actually necessary, it is best to just try deleting it and running

mvn clean verify -Dtest=InjectedTest

@jglick
jglick merged commit 0085973 into jenkinsci:master Apr 10, 2023
@jglick
jglick deleted the parent branch April 10, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants