Skip to content

Resolved mismatch stubbings in SubversionSCMTest.java#351

Merged
MarkEWaite merged 1 commit into
jenkinsci:masterfrom
ARMS2025:resolve-mismatch-stubbings-1
Dec 10, 2025
Merged

Resolved mismatch stubbings in SubversionSCMTest.java#351
MarkEWaite merged 1 commit into
jenkinsci:masterfrom
ARMS2025:resolve-mismatch-stubbings-1

Conversation

@ARMS2025

Copy link
Copy Markdown
Contributor

Description

I analyzed the test doubles (mocks) in the test code of the project. In my analysis of the project, I observed that

In tests multipleRepositoriesSvn17, pollingExternalsForFileSvn16, and pollingExternalsForFileSvn17:

  • the req object:
    i) is created in AbstractSubversionTest.configureSvnWorkspaceFormat
    ii) during test execution calls the getParameter method with argument "svn.global_excluded_revprop", but is not stubbed, resulting in a mismatch stubbing.

In general, a mismatched stubbing occurs when a method is stubbed with specific arguments in a test but later invoked with different arguments in the code. Mockito recommends addressing this type of issue (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org.mockito/org/mockito/exceptions/misusing/PotentialStubbingProblem.html).

I propose a solution below to resolve the mismatch stubbing. Happy to modify the pull request based on your feedback.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry (Not applicable)
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira (Not applicable)
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue (Not applicable)

MarkEWaite added a commit to MarkEWaite/repository-permissions-updater that referenced this pull request Dec 3, 2025
@MarkEWaite
MarkEWaite merged commit 14339e5 into jenkinsci:master Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants