Add ssh-ed25519 and ecdsa-sha2-nistp256 algorithms to ManuallyProvidedKeyVerificationStrategy SSH key help text#522
Merged
Conversation
…dKeyVerificationStrategy SSH key help text
kuisathaverat
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently ManuallyProvidedKeyVerificationStrategy
SSH keyhelp text only mentionsssh-rsaandssh-dsswhilessh-ed25519andecdsa-sha2-nistp256are supported too. It made me spend too much time trying to debug why Jenkins could not establish connection usingssh-rsakey, while it was usingssh-ed25519and I had no idea I can putssh-ed25519key there.Testing done
Don't think there is much to test
Submitter checklist