Expose usernameVariable and timeoutMinutes in the step UI - #293
Merged
ogulcanaydogan merged 1 commit intoJul 29, 2026
Merged
Conversation
These optional step parameters were only settable from pipeline script. Add them to the Snippet Generator form under Advanced, with help text, so they can also be configured through the UI. Includes a config round-trip test. Signed-off-by: Ogulcan Aydogan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
usernameVariableandtimeoutMinutesstep parameters were only settable from pipeline script. This exposes them in the Snippet Generator form under an Advanced section, with help text, so they can be configured through the UI as well.Testing
Adds
SSHAgentStepConfigRoundTripTest, which sets the options and verifies they survive aStepConfigTesterconfig round-trip.mvn test -Dtest=SSHAgentStepConfigRoundTripTestpasses.