Migrate tests to JUnit Jupiter - #167
Merged
ogulcanaydogan merged 2 commits intoJul 23, 2026
Merged
Conversation
Contributor
Author
|
@jenkinsci/ssh-agent-plugin-developers Kindly requesting a review. |
* Migrate annotations and imports * Migrate assertions * Remove public visibility for test classes and methods * Minor code cleanup * Ban JUnit4 imports
The exec unit tests and the sshagent step tests were added after this pull request was opened and still used JUnit 4, which the new banned imports enforcer rejects. Migrate them to JUnit Jupiter so the whole test tree is consistent. Signed-off-by: Ogulcan Aydogan <[email protected]>
ogulcanaydogan
force-pushed
the
migrate_to_jupiter
branch
from
July 22, 2026 10:15
cb82d6b to
6a46435
Compare
jglick
reviewed
Jul 29, 2026
| sc.close(); | ||
|
|
||
| assertEquals(socketFile.toString(), 2, socketFile.size()); | ||
| assertEquals(2, socketFile.size(), socketFile.toString()); |
jglick
reviewed
Jul 29, 2026
| WorkflowRun run = story.j.assertBuildStatusSuccess(job.scheduleBuild2(0)); | ||
| story.j.assertLogContains("Failed to run ssh-agent -k", run); | ||
| WorkflowRun run = j.assertBuildStatusSuccess(job.scheduleBuild2(0)); | ||
| j.assertLogContains("Failed to run ssh-agent -k", run); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate all tests to JUnit Jupiter. Changes include:
I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.
Submitter checklist