SECURITY-2401 Fix credentials leakage to Splunk#20
Closed
pyieh wants to merge 3 commits into
Closed
Conversation
… version 1137.v36a_8153e5c69 (PR-166)
5 tasks
pyieh
marked this pull request as draft
May 18, 2022 23:59
|
Thanks |
fengxx
reviewed
May 23, 2022
Author
|
@fengxx I have updated the pom dependencies to only what's needed |
|
this is fixed and released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof-of-concept for fix for SECURITY-2401 using incremental workflow-api version 1137.v36a_8153e5c69 (PR-166).
Overrides new TaskListenerDecorator.Factory.isAppliedBeforeMainDecorator() method to reorder the SplunkTaskListenerFactory to get access to the console output last such that any sensitive data (e.g. via the credentials-binding plugin) will be masked by the time the LabelConsoleLineStream gets access to the data stream.