Skip to content

Add Configuration as Code support for Scriptler#193

Merged
mtughan merged 5 commits into
jenkinsci:mainfrom
somiljain2006:JCasC
Jul 6, 2026
Merged

Add Configuration as Code support for Scriptler#193
mtughan merged 5 commits into
jenkinsci:mainfrom
somiljain2006:JCasC

Conversation

@somiljain2006

@somiljain2006 somiljain2006 commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes jenkinsci/configuration-as-code-plugin#2457

Add Configuration as Code support for the Scriptler plugin.

  • Add a RootElementConfigurator for Scriptler
  • Support importing Scriptler settings and scripts from JCasC
  • Support exporting Scriptler configuration
  • Persist script contents to the Scriptler script directory

Testing done

  • Added automated tests for JCasC import, export, and round-trip configuration.
  • Verified all tests pass.
  • Manually verified JCasC import using mvn hpi:run.
  • Confirmed configured scripts appear in the Scriptler UI.
  • Confirmed script files are written to the Scriptler scripts directory.
  • Confirmed JCasC export correctly includes the scriptler configuration.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@somiljain2006

somiljain2006 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@mtughan Can you review this pr?

mtughan
mtughan requested changes Jul 3, 2026
View reviewed changes

@mtughan mtughan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the unit test yet, but I found the following.

Comment thread src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptlerConfigurator.java Outdated
Comment thread src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptlerConfigurator.java Outdated
Comment thread src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptlerConfigurator.java Outdated
@somiljain2006
somiljain2006 requested a review from mtughan July 4, 2026 08:44
@somiljain2006

somiljain2006 commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

@mtughan Can you review the updated changes?

@mtughan
mtughan merged commit dc88258 into jenkinsci:main Jul 6, 2026
17 checks passed
@somiljain2006
somiljain2006 deleted the JCasC branch July 6, 2026 19:06
@somiljain2006 somiljain2006 mentioned this pull request Jul 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtughan mtughan mtughan approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Configuration As Code Plugin compatible with Scriptler

2 participants

@somiljain2006 @mtughan