Catch canceled step and mark build has failure#219
Merged
dheid merged 2 commits intojenkinsci:mainfrom Oct 12, 2024
Merged
Conversation
Contributor
Author
|
I am in the process of writing a test to cover this and will update the PR once I have finished. |
When using the Parameterized plugin, the triggered job can be canceled. That causes an `AbortException` to be thrown. Since it is not handled, PostBuildScript let it through and the build is marked in failure even when one explicitly asks to ignore any error. Catch `AbortException` and mark the build has being in failure in such a case instead of bubbling up the exception. Fixes: https://phabricator.wikimedia.org/T352319
hashar
force-pushed
the
handle-cancelled-steps
branch
from
5e56471 to
0efc8d5
Compare
Contributor
|
Thanks for the contribution, @hashar ! Sorry, that I didn't react earlier. I somehow must have overseen it. |
Contributor
Author
|
@dheid no worries and thank you for the review, merge and release! I found another issue which this times lie in the parameterized plugin :-] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the Parameterized plugin, the triggered job can be canceled. That causes an
AbortExceptionto be thrown. Since it is not handled, PostBuildScript let it through and the build is marked in failure even when one explicitly asks to ignore any error.Catch
AbortExceptionand mark the build has being in failure in such a case instead of bubbling up the exception.Fixes: https://phabricator.wikimedia.org/T352319
Before submitting a pull request, please make sure the following is done:
master.mvn clean verify).mvn hpi:runand go to http://localhost:8080/jenkins/ to test your changes. Add a job that produces your bug / feature scenario.