configuration not anymore needed with last release of m-compiler-plugin#240
Closed
configuration not anymore needed with last release of m-compiler-plugin#240
Conversation
Member
olamy
commented
Mar 15, 2022
olamy
commented
- Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
- Ensure that the pull request title represents the desired changelog entry
- Please describe what you did
- Link to relevant issues in GitHub or Jira
- Link to relevant pull requests, esp. upstream and downstream changes
- Ensure you have provided tests - that demonstrates feature works or fixes the issue
basil
requested changes
Mar 16, 2022
Member
basil
left a comment
basil
left a comment
There was a problem hiding this comment.
Steps to reproduce
See JENKINS-67960 and #235.
- Build and install this PR with
mvn clean installto obtain1.73-SNAPSHOT. git clone https://github.com/basil/acceptance-test-harness.gitcd acceptance-test-harnessgit checkout jsr305sed -i -e 's/1.51/1.73-SNAPSHOT/g' pom.xml- Verify this PR has taken effect by running
mvn help:effective-pom | grep forceJavacCompilerUseand ensure there are no results. - Verify Maven Compiler Plugin 3.10.1 is in use by running
mvn help:effective-pom | grep maven-compiler-plugin.versionand ensure you see<maven-compiler-plugin.version>3.10.1</maven-compiler-plugin.version>. - With Java 11, run
mvn clean verify -Denforcer.skip.
Expected results
(Note: These are the actual results when running mvn clean verify -Denforcer.skip -Dmaven.compiler.forceJavacCompilerUse=true or when running with POM 1.72 from before this PR.)
The build fails with a readable message with the compilation error:
[…]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project acceptance-test-harness: Compilation failure: Compilation failure:
[ERROR] /tmp/acceptance-test-harness/src/main/java/org/jenkinsci/test/acceptance/po/PageAreaImpl.java:[7,38] error: package edu.umd.cs.findbugs.annotations does not exist
[…]
[ERROR] /tmp/acceptance-test-harness/src/main/java/org/jenkinsci/test/acceptance/update_center/PluginSpec.java:[45,19] error: cannot find symbol
[ERROR] symbol: class NonNull
[ERROR] location: class PluginSpec
[…]
Actual results
The build fails without printing a readable message with the compilation error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project acceptance-test-harness: Fatal error compiling: CompilerException: NullPointerException -> [Help 1]
Evaluation
The workaround delivered in Maven Compiler Plugin 3.10.1 appears to be incomplete, as the original problem can still be reproduced. Therefore, I conclude #235 is still needed at the present time.
6 tasks
Member
Author
|
interesting one...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.