Upgrade palantir-java-format to Java 21 compatible release#816
Merged
Conversation
timja
approved these changes
Aug 7, 2023
NotMyFault
approved these changes
Aug 7, 2023
NotMyFault
left a comment
NotMyFault
left a comment
Member
There was a problem hiding this comment.
Do certain conditions need to be satisfied for it to fail? I don't encounter these issues in design library, but text-finder.
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
palantir-java-formatwith Java 21, the current release fails withjava.lang.NoSuchMethodError: 'com.sun.tools.javac.tree.JCTree com.sun.tools.javac.tree.JCTree$JCImport.getQualifiedIdentifier()'. This error was fixed in palantir/palantir-java-format#909 and released in 2.35.0; however, pending diffplug/spotless#1774 that version is not used by Spotless. This PR adopts the workaround suggested in diffplug/spotless#1774 (comment) by pinning the version until such a time that Spotless delivers version 2.35.0 by default.Testing done
Ran
mvn clean verifyintext-finderbefore these changes on Java 11, 17, and 21. 11 and 17 passed; 21 failed with the error reported above. After these changes, passed on 11, 17, and 21.