Flatten repositories from JEP-229 plugins#802
Merged
Conversation
This workarounds mojohaus/flatten-maven-plugin#362 and strips <repositories> from deployed pom for plugins using JEP-229
jglick
approved these changes
Jul 6, 2023
jglick
left a comment
jglick
left a comment
Member
There was a problem hiding this comment.
Would also be great to have an IT covering the basic build cycle of a JEP-229-based plugin unlike
and the validation script could do some stuff like assert that the top-level POM elements are only those in a specified list.
jglick
reviewed
Jul 6, 2023
Co-authored-by: Jesse Glick <[email protected]>
Member
Author
I'll see what I can do |
jglick
approved these changes
Jul 6, 2023
| assert installedPom.text.contains("<scm>") | ||
| assert !installedPom.text.contains("<properties>") | ||
| assert !installedPom.text.contains("<dependencyManagement>") | ||
| assert !installedPom.text.contains("<repositories>") |
Co-authored-by: Jesse Glick <[email protected]>
Member
|
Does this need to be side-ported to https://github.com/jenkinsci/pom? |
Vlatombe
added a commit
to Vlatombe/pom
that referenced
this pull request
Jul 12, 2023
Vlatombe
added a commit
to Vlatombe/pom
that referenced
this pull request
Jul 12, 2023
Member
Author
|
Good point, jenkinsci/pom#464 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This workarounds mojohaus/flatten-maven-plugin#362
and strips
<repositories>from deployed pom for plugins using JEP-229.Testing done