[SECURITY-2220] Escape plot description#72
Merged
Conversation
Wadeck
approved these changes
Jul 8, 2022
Wadeck
left a comment
Wadeck
left a comment
There was a problem hiding this comment.
Not manually tested but that's the kind of correction that was expected 👍
Contributor
Author
|
Now, how to continue from here? |
|
Manually tested:
It's working as expected, great job. Next step:
|
daniel-beck
reviewed
Jul 12, 2022
| <j:if test="${it.getPlotDescription(index) != null}"> | ||
| <j:if test="${!it.getPlotDescription(index).isEmpty()}"> | ||
| <b>Description</b>: <j:out value="${it.getPlotDescription(index)}"/> | ||
| <b>Description</b>: <span>${it.getPlotDescription(index)}</span> |
Member
There was a problem hiding this comment.
Doesn't even need the span.
<b>Description</b>: ${it.getPlotDescription(index)}
would do it.
Note that j:out specifically disables the effect of escape-by-default and prints it verbatim. (Its counterpart st:out always escapes what's printed, luckily there's no chance of anyone ever confusing the two 😫 .)
Contributor
Author
|
@ericbn could you consider a new release so we can install a fixed version please? |
Contributor
Author
Member
|
I am not a maintainer of plot |
Member
|
Version 2.1.11 released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naive approach to address SECURITY-2220.
<j:out … />seems to ignore escape-by-default, using a simple<span>…</span>instead escapes the value.@Wadeck @daniel-beck
What has been done
How to test
Checklist
.github/release-drafter.yml)