[JENKINS-64341] Fix for tables-to-divs#65
Conversation
|
cc @timja, @fqueiruga, @fbelzunc |
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=========================================
Coverage 43.38% 43.38%
Complexity 190 190
=========================================
Files 18 18
Lines 1263 1263
Branches 192 192
=========================================
Hits 548 548
Misses 651 651
Partials 64 64
Continue to review full report at Codecov.
|
| @@ -0,0 +1,16 @@ | |||
| <?jelly escape-by-default='true'?> | |||
| <j:jelly xmlns:j="jelly:core" xmlns:d="jelly:define" xmlns:f="/lib/form" xmlns:l="/lib/layout"> | |||
There was a problem hiding this comment.
can we just bin this, it looks horrid on themed Jenkins and doesn't seem to add any value on non themed.
After removal:
Current look on default theme:
Current look on dark theme:
There was a problem hiding this comment.
I've removed the div background. Keeping blockWrapperBackground.jelly so the tables in the old version remains still have the background color
There was a problem hiding this comment.
any reason for keeping it there too? I didn't check what it looks like in the old version without the bg
There was a problem hiding this comment.
It's just that I didn't want to modify the original behavior with tables. But If you think that there is not problem with that I can remove blockWrapperBackground.jelly and reuse blockWrapper.jelly. But we will lose the gray background in Jenkins old versions.
There was a problem hiding this comment.
I would remove it, but not a blocker and not a maintainer here
Co-authored-by: Tim Jacomb <[email protected]>
Co-authored-by: Tim Jacomb <[email protected]>
|
I can't wait for this to get merged |
|
Thank you all for the contribution and reviews here. I'm on very limited availability last weeks so not even sure when I could provide support here. For those reasons I've added a |
5 participants
Jira: JENKINS-64341
What has been done
Screenshots
How to test
Checklist
.github/release-drafter.yml)