Skip to content

Add missing PlotBuild#getDescription() method#59

Merged
vgaidarji merged 1 commit into
masterfrom
JENKINS-61412-add-missing-getter
Mar 11, 2020
Merged

Add missing PlotBuild#getDescription() method#59
vgaidarji merged 1 commit into
masterfrom
JENKINS-61412-add-missing-getter

Conversation

@vgaidarji

@vgaidarji vgaidarji commented Mar 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Jira: JENKINS-61412

What has been done

  1. Added missing PlotBuild#getDescription() method

How to test

  1. Create pipeline job with sample Jenkinsfile and trigger the build
node {
    sh '''
    OUTFILE="test.csv";
    echo "Avg,Median,90,min,max,samples,errors,error %" >> $OUTFILE;
    echo "1234,1906,117,200,29,97560,1170,15" >> $OUTFILE;
    '''
        
    plot csvFileName: "plot-1", csvSeries: [[displayTableFlag: true, exclusionValues: '', file: "test.csv", inclusionFlag: 'OFF', url: '']], exclZero: false, group: "group 1", keepRecords: false, logarithmic: false, numBuilds: '', style: 'line', title: "title 1", useDescr: false, yaxis: 'Value', yaxisMaximum: '', yaxisMinimum: ''
}
  1. Make sure no UnsupportedOperationException is thrown to logs (check logs at JENKINS_URL/log/all)
WARNING o.j.p.s.d.DescribableParameter#uncoerce: failed to uncoerce hudson.plugins.plot.PlotBuilder@4bf77f69
java.lang.UnsupportedOperationException: no public field ‘description’ (or getter method) found in class hudson.plugins.plot.PlotBuilder

Checklist

  • Git commits follow best practices
  • Build passes in Jenkins
  • Appropriate tests or explanation to why this change has no tests
  • JIRA issue is well described (problem explanation, steps to reproduce, screenshots)
  • For dependency updates: links to external changelogs and, if possible, full diffs

@vgaidarji vgaidarji self-assigned this Mar 10, 2020
@codecov

codecov Bot commented Mar 10, 2020

Copy link
Copy Markdown

Codecov Report

Merging #59 into master will increase coverage by 1.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #59      +/-   ##
============================================
+ Coverage     42.15%   43.38%   +1.23%     
- Complexity      174      190      +16     
============================================
  Files            18       18              
  Lines          1262     1263       +1     
  Branches        192      192              
============================================
+ Hits            532      548      +16     
+ Misses          666      651      -15     
  Partials         64       64
Impacted Files Coverage Δ Complexity Δ
src/main/java/hudson/plugins/plot/PlotBuilder.java 61.03% <100.00%> (+13.67%) 23.00 <1.00> (+11.00)
src/main/java/hudson/plugins/plot/XMLSeries.java 72.02% <0.00%> (+2.79%) 36.00% <0.00%> (+4.00%)
...ain/java/hudson/plugins/plot/PropertiesSeries.java 57.14% <0.00%> (+2.85%) 4.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a5e1c...f970ba0. Read the comment docs.

@vgaidarji
vgaidarji merged commit 82d15fa into master Mar 11, 2020
@vgaidarji
vgaidarji deleted the JENKINS-61412-add-missing-getter branch March 11, 2020 06:23
@vgaidarji vgaidarji added the bug Bug fix label Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vgaidarji vgaidarji

Labels

bug Bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vgaidarji