Skip to content

Format with spotless#161

Merged
gounthar merged 1 commit into
jenkinsci:masterfrom
MarkEWaite:switch-to-spotless
Jan 6, 2025
Merged

Format with spotless#161
gounthar merged 1 commit into
jenkinsci:masterfrom
MarkEWaite:switch-to-spotless

Conversation

@MarkEWaite

@MarkEWaite MarkEWaite commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

Format with spotless

Replace checkstyle checks with spotless automated code formatting.

Revise the contributing guide to helps contributors provide more valuable with their pull requests. Use the base text from other plugins that I maintain, with the addition of instructions to run the plugin in a development environment and links to the developer guide.

Testing done

Confirmed that automated tests pass and new documentation looks good on GitHub.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Replaces checkstyle checks with spotless automated code formatting.

Revise the contributing guide to helps contributors provide more valuable
with their pull requests.  Use the base text from other plugins that
I maintain, with the addition of instructions to run the plugin in a
development environment and links to the developer guide.
@MarkEWaite MarkEWaite added the chore General project maintenance label Jan 6, 2025
*/
public FormValidation doCheckSeriesFile(@AncestorInPath AbstractProject project,
@QueryParameter String value) throws IOException {
public FormValidation doCheckSeriesFile(@AncestorInPath AbstractProject project, @QueryParameter String value)

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation

Potential CSRF vulnerability: If DescriptorImpl#doCheckSeriesFile connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
*/
public FormValidation doCheckSeriesFile(@AncestorInPath AbstractProject project,
@QueryParameter String value) throws IOException {
public FormValidation doCheckSeriesFile(@AncestorInPath AbstractProject project, @QueryParameter String value)

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check

Potential missing permission check in DescriptorImpl#doCheckSeriesFile

public FormValidation doCheckName(@QueryParameter String value)
throws IOException, ServletException {
public FormValidation doCheckName(@QueryParameter String value) throws IOException, ServletException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation

Potential CSRF vulnerability: If DescriptorImpl#doCheckName connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

public FormValidation doCheckName(@QueryParameter String value)
throws IOException, ServletException {
public FormValidation doCheckName(@QueryParameter String value) throws IOException, ServletException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check

Potential missing permission check in DescriptorImpl#doCheckName
public FormValidation doCheckSeriesFile(
@AncestorInPath AbstractProject<?, ?> project,
@QueryParameter String value) throws IOException {
public FormValidation doCheckSeriesFile(@AncestorInPath AbstractProject<?, ?> project, @QueryParameter String value)

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation

Potential CSRF vulnerability: If PlotDescriptor#doCheckSeriesFile connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
public FormValidation doCheckSeriesFile(
@AncestorInPath AbstractProject<?, ?> project,
@QueryParameter String value) throws IOException {
public FormValidation doCheckSeriesFile(@AncestorInPath AbstractProject<?, ?> project, @QueryParameter String value)

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check

Potential missing permission check in PlotDescriptor#doCheckSeriesFile
@MarkEWaite
MarkEWaite requested a review from gounthar January 6, 2025 17:50

@gounthar gounthar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Mark! 👍

@gounthar
gounthar merged commit 9193982 into jenkinsci:master Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore General project maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants