fix(spotbugs) Changed visibility and line separators to get SpotBugs happy.#131
Closed
gounthar wants to merge 3 commits into
Closed
fix(spotbugs) Changed visibility and line separators to get SpotBugs happy.#131gounthar wants to merge 3 commits into
gounthar wants to merge 3 commits into
Conversation
Bumps [org.jenkins-ci.plugins:plugin](https://github.com/jenkinsci/plugin-pom) from 4.76 to 4.78. - [Release notes](https://github.com/jenkinsci/plugin-pom/releases) - [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-pom@plugin-4.76...plugin-4.78) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
gounthar
added
dependencies
Contributor
|
Thank you for providing this, @gounthar 👍 |
MarkEWaite
reviewed
Mar 25, 2024
| */ | ||
| @SuppressWarnings("visibilitymodifier") | ||
| public transient String urlNumBuilds; | ||
| private transient String urlNumBuilds; |
Contributor
There was a problem hiding this comment.
I've made the mistake in the past of changing the visibility of a public variable and then breaking the serialization of the object or the dependencies that other plugins had on the object.
It seems simpler to exclude the spotbugs warning in these types of cases rather than risk incompatibility for users.
Contributor
Author
There was a problem hiding this comment.
Got it, thanks.
I have proposed #132 then.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I started from #129 before it closed, this should also "solve" Bump org.jenkins-ci.plugins:plugin from 4.76 to 4.78.
https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.78
https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.77
What has been done
I changed the visibility of the few fields that were bothering SpotBugs.
There also is a change in a Jelly file because it was not using unix-like end-of-line.
How to test
mvn clean verifyChecklist
.github/release-drafter.yml)JIRA issue is well described (problem explanation, steps to reproduce, screenshots)