Reduce Jenkinsfile diffs to archetype#121
Merged
MarkEWaite merged 2 commits intoAug 27, 2023
Merged
Conversation
Use the Jenkins plugin archetype as much as possible as we can so that the differences to the archetype are clear and intentionally used. Tests with Java 21 on Linux and Java 17 on Windows. Accepts that tests on Java 11 are redundant since we've not detected relevant issues that are specific to Java 11. Confirmed that tests pass on Linux with Java 17 and Java 21. Rely on ci.jenkins.io to test Windows. Includes forkCount setting because it improves test performance on ci.jenkins.io and reduces cost on ci.jenkins.io.
Use the Jenkins plugin archetype as much as possible as we can so that the differences to the archetype are clear and intentionally used. Tests with Java 21 on Linux and Java 17 on Windows. Accepts that tests on Java 11 are redundant since we've not detected relevant issues that are specific to Java 11. Confirmed that tests pass on Linux with Java 17 and Java 21. Rely on ci.jenkins.io to test Windows. Does not include forkCount setting because the setting was not enabled previously.
gounthar
approved these changes
Aug 27, 2023
gounthar
left a comment
gounthar
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
Thanks, Mark. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce Jenkinsfile diffs to archetype
Use the Jenkins plugin archetype as much as possible as we can so that the differences to the archetype are clear and intentionally used.
Tests with Java 21 on Linux and Java 17 on Windows. Accepts that tests on Java 11 are redundant since we've not detected relevant issues that are specific to Java 11.
Testing done
Confirmed that tests pass on Linux with Java 17 and Java 21.
Rely on ci.jenkins.io to test Windows.
Submitter checklist