2.2234 serial form incompatibility#770
Merged
jglick merged 8 commits intojenkinsci:masterfrom Mar 4, 2025
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| private static final Logger LOGGER = Logger.getLogger(Upgrade.class.getName()); | ||
|
|
||
| @Override public void configureShell(CpsFlowExecution context, GroovyShell shell) { |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Potentially unsafe classes
This was referenced Mar 3, 2025
This was referenced Mar 3, 2025
This comment was marked as outdated.
This comment was marked as outdated.
dwnusbaum
approved these changes
Mar 4, 2025
jglick
commented
Jul 22, 2025
| } | ||
| } | ||
|
|
||
| private static boolean isOld(FlowExecutionOwner owner) throws Exception { |
Member
Author
There was a problem hiding this comment.
Note that this trick only works once:
diff --git pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/UpgradeTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/UpgradeTest.java
index 5f3b783f..095ebc62 100644
--- pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/UpgradeTest.java
+++ pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/UpgradeTest.java
@@ -118,6 +118,10 @@ public final class UpgradeTest {
var b = p.getBuildByNumber(1);
r.waitForMessage("Resuming build at ", b);
r.waitForMessage("Ready to run at ", b);
+ });
+ rr.then(r -> {
+ var p = r.jenkins.getItemByFullName("p", WorkflowJob.class);
+ var b = p.getBuildByNumber(1);
var proceed = Path.of(((StringParameterValue) b.getAction(ParametersAction.class).getParameter("PROCEED")).getValue());
System.err.println("Touching " + proceed);
Files.writeString(proceed, "go");
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloudBees-internal issue
For automated testing: #766 (comment): this seems like a cleaner way to run the test—can handle actual agents, and no need to commit binary files.
jenkinsci/kubernetes-plugin#1656 successfully verified via CloudBees proprietary integration test.
Manual testing in Docker-related plugins noted in downstream PRs.