Merged
Conversation
carlossg
approved these changes
Aug 24, 2019
|
@jglick I saw your comment on moby/moby#41285 You should replace this with solution which does bind mount for /var/run/docker.sock then you don't need disable all security features from Docker. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on GKE, and saw something similar running with a Kops cluster on AWS.
Could also experiment with rootless Docker.
Note that every build gets a fresh Docker daemon, so there is no local layer cache between builds. This could make builds slower, though it also means builds are more deterministic and there is no need for a GC system. I have not experimented with using a
PersistentVolumeClaimto retain the daemon storage across builds. Probably better to set up a local registry in the cluster as a proxy, just like we would advise for Maven dependencies and the like.