Pluggable storage trend chart#143
Merged
timja merged 41 commits intojenkinsci:masterfrom Aug 19, 2020
Merged
Conversation
…hading, please please do not pick a different groupId.
… step need not query the implementation just to determine UNSTABLE status.
…y removed the improper exception handling in JUnitResultsStepExecution.
Some tracing call ends up calling the toString and it breaks..
Member
|
From #141 (comment) not sure I understand
For background, originally the trend displayed a graph of all builds, no problem. Then in Jenkins 1.484 (IIRC) lazy loading was introduced. I soon found that the trend graph forced every build to be loaded, so I capped the number of builds considered. If we have, say, SQL storage of results then there is no reason not to go back to showing the complete graph. |
Member
Author
|
Ok sure, then no need to do that then. This works and is super quick (as you would expect from a sql based implementation) |
Member
Author
|
I'm going to proceed with merging to make iterating easier in smaller PRs, this PR is likely going to be needed in a couple of others. but feel free:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #141
Part of #142