-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
Update htmlunit to 3.x #8050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update htmlunit to 3.x #8050
Conversation
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
NotMyFault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
basil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
De minimis (test code)
Part of jenkinsci/jenkins-test-harness#568
Followed the migration guide
Testing done
Ran
mvn test -Dtest=lib.form.OptionTestlocallyProposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge:upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).