Skip to content

JENKINS-55920: add CasC support to GitHubPluginConfig. #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dgarzon wants to merge 3 commits into from
Closed

JENKINS-55920: add CasC support to GitHubPluginConfig. #205

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bed1b8
JENKINS-55920: add CasC support to GitHubPluginConfig.
Feb 1, 2019
9389d8b
JENKINS-55920: address PR comments.
Feb 1, 2019
8f4a7e4
Address PR comments
dgarzon Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/main/java/org/jenkinsci/plugins/github/config/GitHubPluginConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
import org.kohsuke.accmod.Restricted;
import org.kohsuke.accmod.restrictions.DoNotUse;
import org.kohsuke.github.GitHub;
import org.kohsuke.stapler.DataBoundConstructor;
import org.kohsuke.stapler.DataBoundSetter;
import org.kohsuke.stapler.QueryParameter;
import org.kohsuke.stapler.StaplerRequest;
import org.kohsuke.stapler.interceptor.RequirePOST;
Expand Down Expand Up @@ -85,6 +87,7 @@ public GitHubPluginConfig(List<GitHubServerConfig> configs) {
}

@SuppressWarnings("unused")
@DataBoundSetter
public void setConfigs(List<GitHubServerConfig> configs) {
this.configs = configs;
}
Expand All @@ -97,6 +100,7 @@ public boolean isManageHooks() {
return from(getConfigs()).filter(allowedToManageHooks()).first().isPresent();
}

@DataBoundSetter
public void setHookUrl(URL hookUrl) {
if (overrideHookUrl) {
this.hookUrl = hookUrl;
Expand All @@ -105,6 +109,12 @@ public void setHookUrl(URL hookUrl) {
}
}

@SuppressWarnings("unused")
public boolean isOverrideHookUrl() {
return overrideHookUrl;
}

@DataBoundSetter
public void setOverrideHookUrl(boolean overrideHookUrl) {
this.overrideHookUrl = overrideHookUrl;
}
Expand Down Expand Up @@ -258,6 +268,7 @@ public HookSecretConfig getHookSecretConfig() {
return hookSecretConfig;
}

@DataBoundSetter
public void setHookSecretConfig(HookSecretConfig hookSecretConfig) {
this.hookSecretConfig = hookSecretConfig;
}
Expand Down