[JENKINS-71749] Add stable order when searching for repositories in GH organization #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jesse Glick <[email protected]> Co-authored-by: Carroll Chiou <[email protected]> Co-authored-by: ARUS2023 <[email protected]> Co-authored-by: Bruno Verachten <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: spotoczny <[email protected]> Co-authored-by: Marcin Kasinski <[email protected]>
vanta
changed the title
jtnord
changed the title
jtnord
approved these changes
Oct 23, 2025
Comment on lines
+1140
to
+1144
| List<String> repoList = StreamSupport.stream(repositories.spliterator(), false) | ||
| .map(GHRepository::getName) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| String repoString = String.join(",", repoList); |
Member
There was a problem hiding this comment.
NIT, slightly inefficient vs creating the string without the intermediate map (e.g. untested)
Suggested change
| List<String> repoList = StreamSupport.stream(repositories.spliterator(), false) | |
| .map(GHRepository::getName) | |
| .collect(Collectors.toList()); | |
| String repoString = String.join(",", repoList); | |
| String repoString = StreamSupport.stream(repositories.spliterator(), false) | |
| .map(GHRepository::getName) | |
| .collect(Collectors.joining(", ")); |
Member
|
Thank you for your contribution @vanta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JENKINS-71749
When scanning the organization, repositories are obtained using
searchGH API. Results are paged by100items, in SR we have more repositories so the final result is the result of multiple paged calls. There is no sorting order set when repos are fetched, resulting in abest-matchsorting (according to GH), which turned out to be not a stable sort - the same repository was returned twice or even three times on multiple pages, and other repositories were lost. As a result, we observed that jobs were disappearing on Jenkins in the Org Folder.This PR adds stable sorting, based on the repository name, so no results are lost.
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify