Fix Casc test upgrading after upgrading to CasC 1995.v540b_50a_eb_0c1 #896
Conversation
jgarciacloudbees
force-pushed
the
cascUpdate
branch
from
9c97264 to
ecc12b8
Compare
| <!-- TODO: remove when included in jenkins-bom via parent --> | ||
| <version>1995.v540b_50a_eb_0c1</version> |
There was a problem hiding this comment.
Normally these overrides would be kept in dependencyManagement for clarity, but OK.
| repositoryAccessStrategy: | ||
| specificRepositories: { | ||
| } |
There was a problem hiding this comment.
Note that all of these cases of empty objects reflect design mistakes in some plugin or another: the configuration code should be fixed to default to null fields. https://www.jenkins.io/doc/developer/plugin-development/pipeline-integration/#handling-default-values is about Pipeline steps but the same principles apply. So if and when those mistakes are fixed, this test would be adjusted correspondingly.
The motivation to skip empty objects in the original JCasC implementation was not explained, but presumably it was an attempt to produce simpler exports by working around these plugin mistakes. Yet it prevented plugins from deliberately treating the presence or absence of an object (typically f:optionalProperty in the GUI) as significant.
3 participants
Description
After the changes implemented on jenkinsci/configuration-as-code-plugin#2712, there are some failing CasC test on the plugin:
com.cloudbees.jenkins.plugins.platform.CasCTest#smokeExport
The idea behind this PR is to upgrade the CasC plugin dependencies to 1995.v540b_50a_eb_0c1 and fix the failing tests.
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify