Skip to content

bugfix: regression in default permissions strategy initialization in GitHubAppCredentials #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeromepochat merged 1 commit into from
Sep 17, 2025
Merged

bugfix: regression in default permissions strategy initialization in GitHubAppCredentials #894

jeromepochat merged 1 commit into from
Sep 17, 2025

Conversation

@lprimak
Copy link
Contributor

@lprimak lprimak commented Sep 17, 2025 •
edited by jeromepochat
Loading

Description

Fixes regression in GitHubAppCredentials.readResolve() when CasC doesn't specify default permissions.
See JENKINS-76072 for further information.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@lprimak lprimak requested a review from a team as a code owner September 17, 2025 02:25
jeromepochat
jeromepochat approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@jeromepochat jeromepochat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot @lprimak!

@jeromepochat jeromepochat merged commit 411feec into jenkinsci:master Sep 17, 2025
15 checks passed
@lprimak lprimak deleted the fix-casc-default-permissions branch September 17, 2025 06:48
@jeromepochat jeromepochat changed the title bugfix: regression in default permissions strategy initialization in … bugfix: regression in default permissions strategy initialization in GitHubAppCredentials Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeromepochat jeromepochat jeromepochat approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lprimak @jeromepochat