[JENKINS-75704] Fix Copilot user null name/email handling #864

IvanGasant · 2025-06-10T08:50:19Z

Description

This PR improves the handling of pull requests and commits authored by GitHub IA, Copilot, who may not have a real GitHub account or may lack a defined name or email.
It prevents exceptions and ensures that these contributions are not discarded during indexing or processing.

Changes

Special handling for the "copilot" user:
- If a pull request is authored by a user with login "copilot", a synthetic ContributorMetadataAction is created with:
  - Name: "copilot"
  - Email: "[email protected]"
- This ensures PRs from Copilot are processed and visible, even though "copilot" is not a real GitHub user.
Other users:
- For all other users, the contributor metadata is still created using the values returned by the GitHub API (login, name, and email) with no fallback.
  If user.getName() or user.getEmail() are null, those fields will remain null as before.
Unchanged logic for missing users:
- If the user does not exist (for example, if the API returns 404), the PR is still ignored just like before.

Motivation

GitHub Copilot and other bots can appear as authors of commits and pull requests, but may not exist as real users in GitHub.
Without this special handling, such PRs would be discarded or cause exceptions, impacting the visibility and traceability of AI-generated or bot-generated contributions.

See JENKINS-75704 for further information.

Submitter checklist

Link to JIRA ticket in description, if appropriate.
Change is code complete and matches issue description
Automated tests have been added to exercise the changes

No automated tests were added because this is a trivial change: it only handles null values or exceptions when fetching the GitHub user's name/email for logging purposes, defaulting to safe values if missing. It does not affect business logic or the core functionality of the plugin.

Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

Run the changes and verify that the change matches the issue description
Reviewed the code
Verified that the appropriate tests have been written or valid explanation given

Documentation changes

Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

…pdate tests - Updated logic so that only the copilot user is allowed to bypass missing name and email checks in pull request processing. - All other users without name/email are marked as unknown and a log message is generated. - Added and updated tests to verify that copilot is accepted and handled as expected.

jglick · 2025-06-20T22:11:02Z

Fallback for missing user name or email:

* For all other users, if `user.getName()` or `user.getEmail()` are `null` or throw exceptions, the code now defaults to:
  
  * Name: `user.getLogin()`
  * Email: `user.getLogin() + "@unknown.user"`

* This prevents exceptions when processing PRs or commits from bot users or users with incomplete profiles.

I see no evidence of such a change in the current patch; did you revert it? If so, please update the PR description accordingly.

jglick · 2025-06-20T22:11:57Z

src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java

                try {
                    user = pr.getUser();
-                    if (users.containsKey(user.getLogin())) {
-                        // looked up this user already


may as well retain this comment in the else clause

jglick · 2025-06-20T22:12:04Z

src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java

-                    ContributorMetadataAction contributor =
-                            new ContributorMetadataAction(user.getLogin(), user.getName(), user.getEmail());
-                    pullRequestContributorCache.put(number, contributor);
-                    // store the populated user record now that we have it


jglick · 2025-06-20T22:12:14Z

src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java

-                    // store the populated user record now that we have it
-                    users.put(user.getLogin(), user);
                } catch (FileNotFoundException e) {
-                    // If file not found for user, warn but keep going


IIUC this was just false.

julianatienza · 2025-07-07T09:53:15Z

Dear @jglick and @IvanGasant , Do you have an estimated timeline for merging this pull request and creating a new release? I'm particularly interested in this fix, as it's currently blocking some of our Jenkins CI/CD workflows when Copilot creates pull requests in our repositories.

Thank you!

gsanchezu · 2025-07-09T11:06:55Z

Hey @IvanGasant , thanks a lot for your contribution!
Hey @jglick , @jenkinsci/github-plugin-owners , @jenkinsci/github-branch-source-plugin-developers , could you please merge this PR?
The issue is currently impacting our Jenkins pipelines and breaking our CI/CD flow.
Thank you so much!

alecharp · 2025-07-09T11:35:37Z

It's true that Jesse did approve the pull request but a few comments were not addressed, specifically about retaining the comments, for future reviewers.

gsanchezu · 2025-07-09T11:44:00Z

It's true that Jesse did approve the pull request but a few comments were not addressed, specifically about retaining the comments, for future reviewers.

Thank you Adrien for your reply.
Hey @IvanGasant , hola! Would it be possible for you to address the pending comments so we can expedite your code to be merged? Muchas gracias!

cristb · 2025-07-09T12:36:50Z

It would be nice if @IvanGasant could manage the comments to merge this PR.
The fix helps us use Copilot in systems with Jenkins in their pipelines.

fruch

LGTM

fruch · 2025-07-24T07:05:48Z

we are running into this issue as well, is there any way around it until this get merged and released ?

IvanGasant · 2025-07-24T20:21:43Z

Hi everyone, thank you for your comments and for your interest in this PR. Apologies for the delay in progressing with this—it’s been a busy period for me, but I plan to resume work on it soon. I’ll make sure to address all suggestions and questions raised and will keep you updated on my progress. If there’s any particular priority or information you need, please let me know.

Thanks again for your patience!

IvanGasant · 2025-07-31T07:43:32Z

Ready for Review @jglick

stale

jglick · 2025-07-31T13:53:16Z

I am not maintaining this plugin, will leave it some other maintainer.

Fix Copilot user null name/email handling

0478e77

IvanGasant requested a review from a team as a code owner June 10, 2025 08:50

Fixing test

d8dec83

IvanGasant marked this pull request as draft June 10, 2025 09:51

IvanGasant added 11 commits June 10, 2025 12:17

Fixing test

261736b

Fixing test

02629fa

Fixing tests

9707e94

Fixing

7a34162

Fixing Format

da39a6c

Create sintetic user for copilot

f0e4131

Fixing format

fcf852d

Optimize code and remove comments

adca923

Fix format

6282a91

Fix format

6242c5f

IvanGasant marked this pull request as ready for review June 11, 2025 18:05

IvanGasant changed the title ~~Fix Copilot user null name/email handling~~ [JENKINS-75704] Fix Copilot user null name/email handling Jun 12, 2025

jglick added the bug label Jun 20, 2025

jglick reviewed Jun 20, 2025

View reviewed changes

jglick previously approved these changes Jun 20, 2025

View reviewed changes

IvanGasant added 2 commits June 25, 2025 13:51

Merge branch 'master' into fix/copilot-null-user

67ecab6

Merge branch 'master' into fix/copilot-null-user

633c26f

Dohbedoh mentioned this pull request Jul 18, 2025

[JENKINS-73791] Prevent PR 404 on details to break Branches scan #811

Merged

8 tasks

olamy approved these changes Jul 18, 2025

View reviewed changes

fruch approved these changes Jul 24, 2025

View reviewed changes

Ivan Garrido and others added 2 commits July 30, 2025 21:31

docs: restore reviewer-requested inline comments in PR user handling

7b76fd7

Merge branch 'master' into fix/copilot-null-user

a0b8737

car-roll approved these changes Jul 31, 2025

View reviewed changes

car-roll merged commit 857721e into jenkinsci:master Jul 31, 2025
17 checks passed

[JENKINS-75704] Fix Copilot user null name/email handling #864

[JENKINS-75704] Fix Copilot user null name/email handling #864

Uh oh!

Conversation

IvanGasant commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Motivation

Submitter checklist

Reviewer checklist

Documentation changes

Users/aliases to notify

Uh oh!

jglick commented Jun 20, 2025

Uh oh!

jglick Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

jglick Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

jglick Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

julianatienza commented Jul 7, 2025

Uh oh!

gsanchezu commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alecharp commented Jul 9, 2025

Uh oh!

gsanchezu commented Jul 9, 2025

Uh oh!

cristb commented Jul 9, 2025

Uh oh!

fruch left a comment

Choose a reason for hiding this comment

Uh oh!

fruch commented Jul 24, 2025

Uh oh!

IvanGasant commented Jul 24, 2025

Uh oh!

IvanGasant commented Jul 31, 2025

Uh oh!

jglick commented Jul 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

IvanGasant commented Jun 10, 2025 •

edited

Loading

gsanchezu commented Jul 9, 2025 •

edited

Loading