Skip to content

Update BOM, update to Jakarta #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alecharp merged 3 commits into from
Jan 14, 2025
Merged

Update BOM, update to Jakarta #823

alecharp merged 3 commits into from
Jan 14, 2025

Conversation

@janfaracik
Copy link
Member

@janfaracik janfaracik commented Jan 13, 2025 •
edited
Loading

Description

Updates the plugin so that it now uses Jakarta over javax, uses the latest LTS.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@janfaracik janfaracik requested a review from a team as a code owner January 13, 2025 10:47
timja
timja approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja timja added the chore label Jan 13, 2025
@alecharp alecharp enabled auto-merge (squash) January 14, 2025 08:46
@timja
Copy link
Member

timja commented Jan 14, 2025

FYI this was needed to compile it on recent cores due to ambiguous methods where null was being passed and the FormException checked exception from credentials

@alecharp alecharp merged commit 088b5f2 into jenkinsci:master Jan 14, 2025
16 of 17 checks passed
@janfaracik janfaracik deleted the update-jakarta branch January 14, 2025 09:37
@basil basil mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alecharp alecharp alecharp approved these changes

@timja timja timja approved these changes

Assignees

No one assigned

Labels

chore developer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janfaracik @timja @alecharp