Skip to content

[JENKINS-73791] Prevent PR 404 on details to break Branches scan #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
car-roll merged 3 commits into from
Jul 18, 2025
Merged

[JENKINS-73791] Prevent PR 404 on details to break Branches scan #811

car-roll merged 3 commits into from
Jul 18, 2025

Conversation

@Dohbedoh
Copy link
Contributor

@Dohbedoh Dohbedoh commented Sep 19, 2024 •
edited
Loading

Description

JENKINS-73791: The retrieval of branches can fail the entire Branch Scanning if a BranchDiscoveryTrait strategy that involves checking on PRs is used while some PR parts cannot be retrieved with a 404 FileNotFoundException.

This is an extension of JENKINS-56996 / #224.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@jenkinsci/github-branch-source-plugin-developers

@Dohbedoh Dohbedoh requested a review from a team as a code owner September 19, 2024 05:56
@Dohbedoh
Copy link
Contributor Author

Dohbedoh commented Sep 19, 2024

First commit to reproduce the failure.
Second commit coming soon to demonstrate the fix.

@Dohbedoh
Copy link
Contributor Author

Dohbedoh commented Nov 15, 2024

@dwnusbaum @jeromepochat @rsandell Can we merge this ?

@BorisYaoA
Copy link

BorisYaoA commented Mar 27, 2025

LGTM

@jglick
Copy link
Member

jglick commented Mar 27, 2025

Does #840 not cover this case?

@Dohbedoh
Copy link
Contributor Author

Dohbedoh commented Apr 22, 2025

@jglick Nope. That #840 is for the Organization Scan. This here is for Branch Indexing.

@Dohbedoh
Copy link
Contributor Author

Dohbedoh commented Jul 18, 2025

NOTE: Copilot is also an example that interrupts branch indexing. It will be handled specifically at #864.

@car-roll car-roll merged commit 185c898 into jenkinsci:master Jul 18, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@car-roll car-roll car-roll approved these changes

+1 more reviewer

@BorisYaoA BorisYaoA BorisYaoA approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dohbedoh @BorisYaoA @jglick @car-roll