Skip to content

[JENKINS-73388] Allow alternative implementation for GitHub App credentials #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
car-roll merged 2 commits into from
Jul 17, 2024
Merged

[JENKINS-73388] Allow alternative implementation for GitHub App credentials #796

car-roll merged 2 commits into from
Jul 17, 2024

Conversation

@jeromepochat
Copy link
Contributor

@jeromepochat jeromepochat commented Jul 9, 2024 •
edited
Loading

This encapsulate fields making possible to extend GitHubAppCredentials to retrieve properties from an alternative storage instead of field values.

Pseudo code:

class AlternativeGitHubAppCredentials extends GitHubAppCredentials {

    @Override
    public getAppID() {
        return retrieveFromExternalSystem("appId");
    }

    @Override
    public getPrivateKey() {
        return retrieveFromExternalSystem("privateKey");
    }
}

See JENKINS-73388 for further information.

@jeromepochat jeromepochat requested a review from a team as a code owner July 9, 2024 21:48
@jeromepochat jeromepochat mentioned this pull request Jul 9, 2024
Closed
8 tasks
car-roll
car-roll approved these changes Jul 17, 2024
View reviewed changes
Copy link

@car-roll car-roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@car-roll car-roll merged commit 5a78598 into jenkinsci:master Jul 17, 2024
@jeromepochat jeromepochat deleted the JENKINS-73388-fields-encapsulation branch July 17, 2024 14:40
@jeromepochat jeromepochat restored the JENKINS-73388-fields-encapsulation branch July 17, 2024 14:40
@jeromepochat jeromepochat deleted the JENKINS-73388-fields-encapsulation branch July 17, 2024 14:40
@jeromepochat jeromepochat mentioned this pull request Aug 20, 2024
Merged
jglick
jglick reviewed Aug 20, 2024
View reviewed changes
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubAppCredentials.java
clone.owner = owner;
new GitHubAppCredentials(getScope(), getId(), getDescription(), getAppID(), getPrivateKey());
clone.apiUri = getApiUri();
clone.owner = getOwner();
Copy link
Member

@jglick jglick Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#803

@jeromepochat jeromepochat mentioned this pull request Aug 21, 2024
Merged
@dwnusbaum dwnusbaum mentioned this pull request Oct 21, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jglick jglick jglick left review comments

@car-roll car-roll car-roll approved these changes

Assignees

No one assigned

Labels

developer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeromepochat @jglick @car-roll