Better symbol for GitSCMSource - #1813
Merged
Merged
Conversation
MarkEWaite
approved these changes
Oct 1, 2025
MarkEWaite
left a comment
MarkEWaite
left a comment
Contributor
There was a problem hiding this comment.
Change looks good to me. Thanks!
MarkEWaite
added a commit
to MarkEWaite/pipeline-groovy-lib-plugin
that referenced
this pull request
Oct 9, 2025
Git plugin 5.8.0 provides the gitSource symbol so that retrievers can replace the $class syntax with the gitSource symbol. Refer to git plugin pull request: * jenkinsci/git-plugin#1813 Without this fix, plugin BOM tests fail. Updates the plugin dependencies to match the dependencies needed by git plugin 5.8.0. Updates include comments to remind that they can be removed once git plugin 5.8.0 is in the plugin BOM. Testing done: * Confirmed that plugin BOM fails without this change: LINE=weekly PLUGINS=pipeline-groovy-lib TEST=LibraryStepTest#configRoundtrip bash ./local-test.sh * Confirmed that plugin tests pass with this change mvn clean verify
Merged
6 tasks
MarkEWaite
added a commit
to MarkEWaite/docker-lfs
that referenced
this pull request
Oct 11, 2025
Arrived with Git plugin 5.8.0 and pull request: * jenkinsci/git-plugin#1813
jglick
added a commit
to jglick/workflow-scm-step-plugin
that referenced
this pull request
Oct 15, 2025
6 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d1ee85b introduced a symbol but it is unusable from Pipeline script, as noted in a similar case in #1373.