Remove useless bridge method injector annotation - #1746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#695 effectively removed the bridge method from the generated bytecode by removing
bridge-method-injectorfrom the build, but it did not remove the@WithBridgeMethodannotation, turning it into dead code. Since the intervening 6 years have clearly demonstrated that the bridge method is not actually needed, remove the useless annotation rather than addingbridge-method-injectorback to the build.Testing done
Dumped the bytecode of the class with
javapbefore and after this change and verified it was the same (i.e., no bridge method both before and after, as expected).Submitter checklist