Skip to content

Remove useless bridge method injector annotation - #1746

Merged
MarkEWaite merged 1 commit into
jenkinsci:masterfrom
basil:bridge
Apr 21, 2025
Merged

Remove useless bridge method injector annotation#1746
MarkEWaite merged 1 commit into
jenkinsci:masterfrom
basil:bridge

Conversation

@basil

@basil basil commented Apr 21, 2025

Copy link
Copy Markdown
Member

#695 effectively removed the bridge method from the generated bytecode by removing bridge-method-injector from the build, but it did not remove the @WithBridgeMethod annotation, turning it into dead code. Since the intervening 6 years have clearly demonstrated that the bridge method is not actually needed, remove the useless annotation rather than adding bridge-method-injector back to the build.

Testing done

Dumped the bytecode of the class with javap before and after this change and verified it was the same (i.e., no bridge method both before and after, as expected).

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@basil basil added the maintenance Reduces maintenance effort by changes not directly visible to users label Apr 21, 2025
@basil
basil requested a review from alecharp April 21, 2025 22:06
@basil
basil requested a review from a team as a code owner April 21, 2025 22:06

@MarkEWaite MarkEWaite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite changed the title Remove useless annotation Remove useless bridge method injector annotation Apr 21, 2025
@MarkEWaite
MarkEWaite merged commit 1a14e55 into jenkinsci:master Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Reduces maintenance effort by changes not directly visible to users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants