[JENKINS-73677] Decorate GitClient after adding credentials - #1649
Merged
Conversation
6 tasks
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Aug 28, 2024
6 tasks
Contributor
Author
|
@jenkinsci/git-plugin-developers Any chance to get this merged ? |
6 tasks
MarkEWaite
added a commit
to MarkEWaite/docker-lfs
that referenced
this pull request
Sep 18, 2024
[JENKINS-73677] Decorate GitClient after adding credentials jenkinsci/git-plugin#1649
MarkEWaite
approved these changes
Sep 18, 2024
MarkEWaite
left a comment
MarkEWaite
left a comment
Contributor
There was a problem hiding this comment.
BOM tests passed with this change. Ready to merge and release
MarkEWaite
added
enhancement
MarkEWaite
added a commit
to MarkEWaite/git-plugin
that referenced
this pull request
Sep 20, 2024
…enkinsci#1649)" This reverts commit 843d48b.
MarkEWaite
added a commit
that referenced
this pull request
Sep 20, 2024
…1649)" https://issues.jenkins.io/browse/JENKINS-73797 reports that Bitbucket branch source plugin multibranch Pipelines are broken by this change if they use ssh access to the repository. Rather than disrupt users by breaking their Pipelines, revert the change and release it so that we have time to evaluate alternatives and to develop better tests. This reverts commit 843d48b.
Member
|
Appears to have broken Bitbucket Branch Source plugin Multibranch Pipeline jobs if they use SSH access to the repository: JENKINS-73797 |
nfalco79
added a commit
to jenkinsci/bitbucket-branch-source-plugin
that referenced
this pull request
Nov 3, 2024
… Bitbucket is null Set the credentialsId returned by the authenticator for SCM. In case of SSH Trait is set git SCM credential to null to re-apply patch jenkinsci/git-plugin#1649
nfalco79
added a commit
to jenkinsci/bitbucket-branch-source-plugin
that referenced
this pull request
Nov 3, 2024
… Bitbucket is null (#899) Set the credentialsId returned by the authenticator for SCM. In case of SSH Trait is set git SCM credential to null to re-apply patch jenkinsci/git-plugin#1649
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JENKINS-73677: Credentials are added to GitClient after the client is decorated by extensions.. A plugin cannot for example override the credentials passed in via a GitSCMExtension (Noticed as part of jenkinsci/bitbucket-branch-source-plugin#867)
Testing done
Tested simple scenario: configured Pipeline from SCM with GitSCM with provided Credentials.
Submitter checklist