Require Java 11 and Jenkins 2.361.4 or newer - #1367
Merged
Merged
Conversation
github-actions
Bot
added
dependencies
MarkEWaite
removed
dependencies
12 tasks
github-actions
Bot
added
dependencies
6 tasks
jglick
reviewed
Dec 5, 2022
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>git-client</artifactId> | ||
| <version>4.0.0-rc3300.80c23f8e08ec</version> |
Member
There was a problem hiding this comment.
FWIW I like to add such things to dependencyManagement with a TODO comment to delete once bom picks it up.
basil
approved these changes
Dec 5, 2022
basil
left a comment
basil
left a comment
Member
There was a problem hiding this comment.
jenkinsci/git-client-plugin#939 and this PR work fine for me on my local Linux development machine with both Freestyle and Pipeline jobs cloning with both command-line Git and JGit on the latest weekly release and Java 19.
MarkEWaite
added a commit
to MarkEWaite/pipeline-groovy-lib-plugin
that referenced
this pull request
Dec 18, 2022
Git plugin 5.0 will require Java 11 and will add symbols to improve the Pipeline syntax editing experience. The test being modified in this pull request checks the specific syntax of the Pipeline snippet syntax generator. Adapt the test to check for current syntax with git plugin 4.x releases and for new syntax with any other releases. jenkinsci/git-client-plugin#939 is the git client plugin pull request that prepares git client plugin 4.0.0. It will require Java 11 and will upgrade from JGit 5.13.1 to JGit 6.4.0. jenkinsci/bom#1619 is the bom draft pull request that confirms git client plugin 4.0.0 pre-release works in the plugin bom. jenkinsci/git-plugin#1367 is the git plugin pull request that prepares git plugin 5.0.0. It will require Java 11. jenkinsci/bom#1624 is the bom draft pull request that tests git plugin 5.0.0 works in the plugin bom. jenkinsci/git-plugin#1373 is the git plugin pull request that relies on jenkinsci/git-plugin#1367 and adds symbols to the git plugin. jenkinsci/bom#1625 is the bom draft pull request that tests git plugin 5.0.0 with added symbols works in the plugin bom. It detected this test failure when run with git plugin 5.0.0 pre-release.
6 tasks
Standard is better than better
The useBeta property is required until Jenkins.MANAGE moves out of Beta.
Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.51 to 4.53. - [Release notes](https://github.com/jenkinsci/plugin-pom/releases) - [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-pom@plugin-4.51...plugin-4.53) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jesse Glick <[email protected]>
Pending release of git client plugin 4.0.0.
MarkEWaite
force-pushed
the
require-java-11
branch
from
December 25, 2022 17:43
5ae823b to
0e0ef7a
Compare
MarkEWaite
removed
dependencies
MarkEWaite
enabled auto-merge (rebase)
December 25, 2022 17:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require Java 11 and Jenkins 2.361.4 or newer
Prepare for git plugin 5.0.0 release with requirement for Java 11 and with additional changes for the addition of Pipeline symbols to make Pipelines easier to express.
Checklist
Types of changes
Further comments
Needs additional testing in:
Once this pull request is merged, then the add-symbols branch needs to be merged (probably after a squash or a rebase to make the history less filled with debris). The "add symbols" change is the reason for the increment of the major version from 4.x to 5.x.
I hope that there is no incompatibility created by the "add symbols" change. I've tested deeply and widely for compatibility in the "add symbols" change. The test automation of the "add symbols" change attempts to verify many different scenarios continue to work after the change. However, it is a large enough change that I believe it justifies incrementing the major version.