Skip to content

Fix JMH environment test setup - #940

Merged
MarkEWaite merged 1 commit into
jenkinsci:masterfrom
MarkEWaite:fix-jmh-execution
Dec 3, 2022
Merged

Fix JMH environment test setup#940
MarkEWaite merged 1 commit into
jenkinsci:masterfrom
MarkEWaite:fix-jmh-execution

Conversation

@MarkEWaite

Copy link
Copy Markdown
Contributor

Fix JMH environment test setup

Introduced in 107bbe0 when I missed that the folder argument could be null. When the folder argument is null, the previous method uses the system temporary directory. This change does the same.

JMH tests will be used to compare JGit 5.13.1 and JGit 6.4.0. This change will allow the JGit 5.13.1 baseline tests to be performed.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • Bug fix in test setup code

Introduced in 107bbe0 when I missed that
the folder argument could be null.  When the folder argument is null,
the previous method uses the system temporary directory. This change
does the same.
@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Dec 3, 2022
@MarkEWaite
MarkEWaite merged commit 788eeda into jenkinsci:master Dec 3, 2022
@MarkEWaite
MarkEWaite deleted the fix-jmh-execution branch December 3, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Automated test addition or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant