Require Java 11 and Jenkins 2.361.4 or newer - #939
Merged
Conversation
Do not want to wrestle with complications for little benefit.
Expect the correct exception on Windows
MarkEWaite
marked this pull request as draft
December 3, 2022 21:48
Member
|
jenkinsci/git-plugin#1367 and this PR work fine for me on my local Linux development machine with both Freestyle and Pipeline jobs cloning with both command-line Git and JGit on the latest weekly release and Java 19. What's your stack trace from the FreeBSD box? |
Contributor
Author
As far as I can tell, the stack traces no longer appear once I explicitly restarted the FreeBSD agents. I'll continue to monitor the behavior. Stack traces reported by various FreeBSD agents running Java 11.0.16 as provided by freebsd-13-b-jagentfreebsd-13-c-jagentfreebsd12-d-jagentgcp-fr3eebsd-13-1-a |
Member
Did you need to restart the whole box or just the Remoting process? Restarting the whole box should not be necessary but I would not be surprised if Remoting was caching loaded classes from before the upgrade leading to a situation where both old and new versions of JGit classes were present in the same classloader at the same time. As annoying as restarting the Remoting process is, it seems like the path of least resistance to simply mention this in the release notes / upgrade documentation. |
Contributor
Author
I disconnected the agent from the Jenkins agents page. No restart of the computer hosting the agent.
I like that suggestion. I thought that I had completely restarted Jenkins after upgrading the plugin, but I may be wrong on that recollection. In any case, it is a good idea to recommend that agents be restarted when the git client plugin is upgraded to use the new JGit library. |
This was referenced Dec 5, 2022
6 tasks
jglick
approved these changes
Dec 5, 2022
basil
approved these changes
Dec 5, 2022
basil
left a comment
basil
left a comment
Member
There was a problem hiding this comment.
jenkinsci/git-plugin#1367 and this PR work fine for me on my local Linux development machine with both Freestyle and Pipeline jobs cloning with both command-line Git and JGit on the latest weekly release and Java 19.
MarkEWaite
marked this pull request as ready for review
December 6, 2022 22:57
Contributor
Author
|
I'm not ready to release it yet, but I've marked it as "Ready for Review" because it has passed automated testing, interactive testing, and plugin compatibility testing in the BOM repository. I hope to release by the end of December 2022, together with a release of git plugin 5.0.0. |
Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.51 to 4.53. - [Release notes](https://github.com/jenkinsci/plugin-pom/releases) - [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-pom@plugin-4.51...plugin-4.53) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
….53' into require-java-11
MarkEWaite
added a commit
to MarkEWaite/pipeline-groovy-lib-plugin
that referenced
this pull request
Dec 18, 2022
Git plugin 5.0 will require Java 11 and will add symbols to improve the Pipeline syntax editing experience. The test being modified in this pull request checks the specific syntax of the Pipeline snippet syntax generator. Adapt the test to check for current syntax with git plugin 4.x releases and for new syntax with any other releases. jenkinsci/git-client-plugin#939 is the git client plugin pull request that prepares git client plugin 4.0.0. It will require Java 11 and will upgrade from JGit 5.13.1 to JGit 6.4.0. jenkinsci/bom#1619 is the bom draft pull request that confirms git client plugin 4.0.0 pre-release works in the plugin bom. jenkinsci/git-plugin#1367 is the git plugin pull request that prepares git plugin 5.0.0. It will require Java 11. jenkinsci/bom#1624 is the bom draft pull request that tests git plugin 5.0.0 works in the plugin bom. jenkinsci/git-plugin#1373 is the git plugin pull request that relies on jenkinsci/git-plugin#1367 and adds symbols to the git plugin. jenkinsci/bom#1625 is the bom draft pull request that tests git plugin 5.0.0 with added symbols works in the plugin bom. It detected this test failure when run with git plugin 5.0.0 pre-release.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require Java 11 and Jenkins 2.361.4 or newer
Switch from Java 8 to Java 11 as minimum Java version. Use JGit 6.4.0 instead of JGit 5.13.x.
Checklist
Types of changes
Further comments
JGit project has dropped support for Java 8 with the release of JGit 6.0. It is time to run exclusively on Java 11 or newer.