Skip to content

Remove dead code from tempfile path sanitizer - #1714

Merged
MarkEWaite merged 1 commit into
jenkinsci:stable-6.4from
MarkEWaite:simplify-sanitization-checks
Dec 18, 2025
Merged

Remove dead code from tempfile path sanitizer#1714
MarkEWaite merged 1 commit into
jenkinsci:stable-6.4from
MarkEWaite:simplify-sanitization-checks

Conversation

@MarkEWaite

Copy link
Copy Markdown
Contributor

Remove dead code from tempfile path sanitizer

Compute the absolute path once, then use the string repeatedly for the comparisons.

Testing done

Rely on ci.jenkins.io. I will test more deeply once I have an incremental build.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Compute the absolute path once, then use the string repeatedly for the comparisons.
@MarkEWaite
MarkEWaite requested a review from a team as a code owner December 17, 2025 22:36
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Dec 17, 2025
@MarkEWaite
MarkEWaite merged commit 8873cd0 into jenkinsci:stable-6.4 Dec 18, 2025
18 checks passed
@MarkEWaite
MarkEWaite deleted the simplify-sanitization-checks branch December 18, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Reduces maintenance effort by changes not directly visible to users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants