Skip to content

[JENKINS-21520] transient NoClassDefFoundError: javax/servlet/ServletException - #171

Merged
MarkEWaite merged 1 commit into
jenkinsci:masterfrom
ndeloof:master
Jul 10, 2015
Merged

[JENKINS-21520] transient NoClassDefFoundError: javax/servlet/ServletException#171
MarkEWaite merged 1 commit into
jenkinsci:masterfrom
ndeloof:master

Conversation

@ndeloof

@ndeloof ndeloof commented Jul 9, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@ndeloof

ndeloof commented Jul 9, 2015

Copy link
Copy Markdown
Contributor Author

Not sure why having a reference to Functions do drag some unexpected classes on slave then breaks ClassLoading, anyway inlining this on-line functions seems a reasonable workaround
@reviewbybees

@ghost

ghost commented Jul 9, 2015

Copy link
Copy Markdown

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@MarkEWaite

Copy link
Copy Markdown
Contributor

Doesn't the reference also need to be removed from src/main/java/hudson/plugins/git/GitTool.java?

Shouldn't it also be removed from src/test/java/org/jenkinsci/plugins/gitclient/WarnTempDirValueTest.java to reduce the risk that someone will see its use in a test and introduce it back into the main code?

@ndeloof

ndeloof commented Jul 9, 2015

Copy link
Copy Markdown
Contributor Author

makes sense indeed

@jenkinsadmin

Copy link
Copy Markdown
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@stephenc

Copy link
Copy Markdown
Member

🐝

MarkEWaite added a commit that referenced this pull request Jul 10, 2015
[JENKINS-21520] transient NoClassDefFoundError: javax/servlet/ServletException
@MarkEWaite
MarkEWaite merged commit 0b57fec into jenkinsci:master Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants